Skip to content

feat: use useVisibleItems in DeprecatedTree#2399

Open
43081j wants to merge 1 commit intomainfrom
jg/visible-depretreetions
Open

feat: use useVisibleItems in DeprecatedTree#2399
43081j wants to merge 1 commit intomainfrom
jg/visible-depretreetions

Conversation

@43081j
Copy link
Copy Markdown
Contributor

@43081j 43081j commented Apr 6, 2026

🔗 Linked issue

N/A

🧭 Context

Part of migrating to the new useVisibleItems composable.

📚 Description

Switches the deprecated notice to use the new useVisibleItems
composable.

@43081j
feat: use useVisibleItems in DeprecatedTree
929903c 
Switches the deprecated notice to use the new `useVisibleItems`
composable.
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 6, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Apr 6, 2026 0:51am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Apr 6, 2026 0:51am
npmx-lunaria Ignored Ignored Apr 6, 2026 0:51am

Request Review

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e6b7b0f4-2b32-46d9-ac7a-230b97c54b9c

📥 Commits

Reviewing files that changed from the base of the PR and between 68abc5d and 929903c.

📒 Files selected for processing (1)
  • app/components/Package/DeprecatedTree.vue
📝 Walkthrough

Walkthrough

The DeprecatedTree.vue component has been refactored to replace its manual pagination logic with a useVisibleItems composable-driven mechanism. Previously, the component directly sliced the deprecated packages array and conditionally showed a "show all" button based on whether the list exceeded five items. The update now renders visibleItems derived from analysisData.deprecatedPackages with a fixed page size of five, uses a hasMorePackages condition for the button visibility, and triggers an expandPackages function instead of mutating the showAll state directly.

Possibly related PRs

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining the migration to the new useVisibleItems composable in the DeprecatedTree component.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jg/visible-depretreetions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@43081j